Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xds-client LrsCallState statsTimer memory leak #2891

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix: xds-client LrsCallState statsTimer memory leak #2891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb6064
fix: xds-client LrsCallState statsTimer memory leak
gfrancz Jan 28, 2025
6dc3abe
Fix type issue by setting the attribute separately
gfrancz Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/grpc-js-xds/src/xds-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,6 +688,14 @@ class LrsCallState {
this.sendStats();
}

destroy() {
if (this.statsTimer) {
clearInterval(this.statsTimer);
this.statsTimer = null;
}
return null;
}

private handleStreamStatus(status: StatusObject) {
this.client.trace(
'LRS stream ended. code=' + status.code + ' details= ' + status.details
Expand Down Expand Up @@ -938,7 +946,7 @@ class XdsSingleServerClient {
}

handleLrsStreamEnd() {
this.lrsCallState = null;
this.lrsCallState = this.lrsCallState ? this.lrsCallState.destroy() : null;
/* The backoff timer would start the stream when it finishes. If it is not
* running, restart the stream immediately. */
if (!this.lrsBackoff.isRunning()) {
Expand Down