fix: replace the deprecated logger.Logf and logger.Log for the new Logger #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @denis256, do we need your review to merge? |
|
Actually, it's just that I can't do the merge. @james03160927 , can you merge the pr? 
|
|
@james03160927 @denis256 do you think we can merge the pr? |
|
Yeah let's merge it. Sorry for the delay. The failing test doesn't seem to be related to your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1448.
Replaces the deprecated
logger.Logfandlogger.Logfor the new Logger.Release Notes (draft)
Removed the use of the deprecated logger.Logf and logger.Log and use the new Logger instead.
Migration Guide
Not required.