-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MVP Huggingface] Define Request Type model and GET data from HuggingFace repos. #1891
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2025-02-05 ticket check in4:30p - 5:30p PT Notes
Action Items
|
Hi @DrAcula27 , Please leave a comment with the following items:
|
Hi all, I have provided links to the new repos I created to help start the section labelled |
Update
|
Based on discussion with dev lead, and instruction from Bonnie, we will be splitting this ticket up into smaller parts so that you may get your work reviewed, and other team members may pick up the other resulting tickets if needed. @DrAcula27, I will be splitting this ticket off right up to "Updating Huggingface Repositories - separate into 3 month chunks". Let me know if you have any concerns about this. If you had begun any Action Items from the sections beyond that^ point, please let me know in a comment below. I am beginning to split up the tickets now. |
@ryanfchase That works for me! I think splitting this into multiple tickets will be helpful. |
I've moved the remaining work into this ticket. @DrAcula27 please assess if the complexity and size match the work you have contributed, and work remaining. |
@ryanfchase I agree with small complexity and 2pt in size. |
Hi Danielle, this is the template I want teams to use for their weekly updates. You can always add more info to the items below 1-4, which are the required minimum. Instructions
|
@DrAcula27 I've added this section to Action Items in order to tee off the next ticket in the blank map feature release:
With this action item added, this is ticket is getting locked in. When you complete all action items, please do the following
|
Intended use of the
|
Performance ComparisonLoad Time Criteria - blank map on start
Results
VSLoad Time Criteria - current setup on start
Results
Blank map is roughly 5.67x faster |
I'm seeing some merge artifacts appearing in this PR, I'd like to address in breakouts tonight:
|
Overview
We need to create a version of our app that initializes the map using one request table since we are loading multiple tables for each year of data.
Developer Info
We are NOT merging this into
develop
. This is meant to be a staging branch for the Blank Map feature ONLYAction Items
Developer Setup
staging-feature-blank-map
feature-blank-map
Developer Actions
/db/DBRequest.jsx
createRequestTable
functionUpdating the logic to insert 2023 - 2024 ONLY data into a single table. (Prevent crashing your local)requests
table on Map initialization (use data model provided) , however do not load any initial datafetchData
indb/DBRequest.jsx
that will be the accessor method for fetching data from external sources (e.g. Socrata, Huggingface)DESCRIBE
call as proof of conceptready for dev lead
Resources/Instructions
Notes
Resources
Code References
createRequestsTable
datasetFileName
and instead we'll simply define the table inlineupdateHfDataset.py
scripts > updateHfDataset.py
timestampformat
The text was updated successfully, but these errors were encountered: