Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One request table #1930

Merged

Conversation

DrAcula27
Copy link
Member

Fixes #1891

What changes did you make?

  • moved the createRequestsTable function into a new file, components/db/DbRequests.jsx
  • changed the createRequestsTable function to create a table, using a manual schema, that is year-agnostic
  • updated the table name across the application to be year-agnostic
  • created a test version of the fetchData function in components/db/DbRequests.jsx that will serve as a replacement for the setData function in components/Map/index.jsx once it is fleshed out

Why did you make the changes?

  • To create a version of the app that initializes the map using one request table instead of one table for each year of data

PR Checks

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Copy link
Member

@funbunch funbunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some merge artifacts appearing in this PR, I think we can perhaps we can either update the hackforla:feature-blank-map branch with latest from main.

@DrAcula27
Copy link
Member Author

@efrenmarin45 and I will work on a rebase of this on Friday.

@DorianDeptuch DorianDeptuch self-requested a review February 22, 2025 18:39
move creation of table to new file.
@DrAcula27 DrAcula27 force-pushed the one-request-table-1891 branch from de1005a to 35b88f7 Compare February 25, 2025 02:53
@DrAcula27 DrAcula27 merged commit 31cc5a7 into hackforla:feature-blank-map Feb 25, 2025
@efrenmarin45
Copy link
Member

@DrAcula27 Reopening PR due to merging conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants