Update styling of service request details modal 1870 #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
ryanfchase
requested changes
Jan 30, 2025
components/Map/Map.jsx
Outdated
| if (!isLoading && this.popup) { | ||
| this.popup.addClassName(this.props.classes.loadedModal); | ||
| } | ||
| this.setState({ isRequestDetailLoading: isLoading }); |
There was a problem hiding this comment.
Is this still needed? I don't see any usage of isRequestDetailLoading besides its definition in state, and it being set here. Perhaps we can get rid of it if it no longer controls the rendering of UI elements.
There was a problem hiding this comment.
Good catch, I've removed it from the component
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This was referenced Feb 1, 2025
This was referenced Feb 11, 2025
|
@DorianDeptuch I have hidden my note about the bug we identified. This will be addressed on #1921, you should move forward with addressing the action items of the ticket. When you are finished, please update your PR |
…ervice-request-details-modal-1870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1870
mainbranchScreenshot before proposed changes
Screenshot after proposed changes
Any questions? See the getting started guide