Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commented out slack router ref #1067

Merged

Conversation

drubgrubby
Copy link
Member

closes #1066

  1. I commented out lines 80 and 120 in backend/app.js and no longer seem to be getting that slack error on startup.
  2. I forgot that I installed Prettier which changed all of the double quotes to single quotes. I'm going to leave it as it does make the code more consistent, unless the reviewer thinks I should do otherwise.

@drubgrubby drubgrubby requested a review from FoxShaunR February 15, 2022 16:57
@drubgrubby drubgrubby marked this pull request as draft February 15, 2022 17:09
@drubgrubby drubgrubby removed the request for review from FoxShaunR February 15, 2022 17:10
@drubgrubby
Copy link
Member Author

Failed backend tests writing env file. Don't have time to investigate now. Changing to draft for the moment.

@drubgrubby drubgrubby requested a review from FoxShaunR February 18, 2022 03:13
@drubgrubby drubgrubby marked this pull request as ready for review February 21, 2022 16:09
@drubgrubby drubgrubby merged commit fe0caa4 into hackforla:development Feb 21, 2022
@drubgrubby drubgrubby deleted the drub_kill-slack-error_1066 branch February 21, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of slack error once and for all
2 participants