Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Tool tips #671

Closed
KPHowley opened this issue Dec 3, 2020 · 8 comments · Fixed by #732
Closed

Refactor: Tool tips #671

KPHowley opened this issue Dec 3, 2020 · 8 comments · Fixed by #732
Assignees
@Jonathanko52 @nclairesays
Labels
level: missing p-feature: Tool Tips priority: Could Have refactor Release Note: Shows as System Update role: front-end Front End Developer size: missing
Milestone
CLOSED - 01 - Cit...

Comments

@KPHowley
Copy link
Member

KPHowley commented Dec 3, 2020

Overview

Some of the tool tips are different on the page, we should refactor them to be consistent.
@KPHowley KPHowley added the role: front-end Front End Developer label Dec 8, 2020
@Jonathanko52 Jonathanko52 self-assigned this Dec 13, 2020
@Jonathanko52
Copy link
Member

Covered in #407, with pull request #681

@VJ1285 VJ1285 added this to the MVP - no date yet assigned milestone Dec 19, 2020
@Jonathanko52
Copy link
Member

-Standardize sidebar and calculator strategies tooltips.
-Both move with mouse.
-Both have arrows.
-Darker blue test (same as current sidebar.)
-Border(same as strategies)
-Background white(same as strategies)

@Jonathanko52
Copy link
Member

Narrowed down that the sidebar uses tooltip.js(from the sidebar field) while the wizard uses react tooltips npm package. Should be a simple fix from here. Eta 1/7

@Jonathanko52
Copy link
Member

Pull request submitted

@Jonathanko52
Copy link
Member

Pull request submitted. Awaiting review.

@nclairesays nclairesays mentioned this issue Jan 20, 2021
Merged
@nclairesays nclairesays self-assigned this Jan 20, 2021
@nclairesays
Copy link
Member

I approving JK's PR but this issue isn't closed yet. I'll work to continue refactoring this.

There are some files that could be deleted, some styling that's passed into a component when the component should already be responsible for its own styling. There's a lot of repetitive code in these tool tips so I will work to refactor and clean them up.

@nclairesays
Copy link
Member

Still need to fix the tool tip that explains the packages when you're on level 1. The ProjectsPackages.js uses the old tool t ip
image

nclairesays added a commit that referenced this issue Jan 20, 2021
@nclairesays
Merge pull request #699 from hackforla/617-Refactor-Tooltips
3968c21 
#671 Refactored Sidebar and Calculator Tooltips
nclairesays added a commit that referenced this issue Jan 20, 2021
@nclairesays
Refactor tooltips some more #671
8668cfc 
  - Remove  -webkit and -moz styling
  - Make tooltip icons responsible for its own styling instead of passing in containerStyle
  - Remove unused questionStyle and circleStyle from ToolTipIcon in RuleCalculation and Sidebar directories
nclairesays added a commit that referenced this issue Jan 20, 2021
@nclairesays
Conditionally render tooltip for Citywide Parking Baseline on page 3 #…
4480e53 
…671
nclairesays added a commit that referenced this issue Jan 20, 2021
@nclairesays
Refactor tooltip to use same component throughout app #671
4c6295b
@nclairesays nclairesays mentioned this issue Jan 20, 2021
Merged
@nclairesays
Copy link
Member

I did some additional refactoring on top of what JK already did (which has already been approved and merged in)

Mostly reorganizing files/components so that they are DRY

  • Created a Tooltip directory with ToolTipIcon.js and ToolTip.js. (This ToolTip.js is different from our previous versions of ToolTip.js)
  • These are the components we should be importing throughout the app, rather than importing directly from the library.
  • These two components are responsible for their own styling. Styling does not get passed into the component anymore.
  • Made all ToolTipIcons the same, with the option of making it a "medium" size via a prop

Bug FIx: Fixed the rendering of tooltip icon for Parking Provided / Baseline and City wide Parking baseline since the icon accidentally got added in

nclairesays added a commit that referenced this issue Jan 23, 2021
@nclairesays
Ensure all tooltip styles are the same and rename tooltip ids #671
12eedfd
nclairesays added a commit that referenced this issue Jan 23, 2021
@nclairesays
Refactor and create ToolTipLabel and RuleInputLabel #671
a55c44e
nclairesays added a commit that referenced this issue Jan 23, 2021
@nclairesays
Delete unused code and styling from RuleInput #671
f01d227
nclairesays added a commit that referenced this issue Jan 28, 2021
@nclairesays
Refactor tooltips pt3 #671
e20d301 
  - Remove unused code
  - Fix tooltip for parking baseline to only show up on tooltip icon (not label)
  - Rename variables and classname
  - Use jss theme colors when hovering on rows
  - Make RuleStrategy and RuleInput styles more consistent with each other
  - Restyled RuleStrategy so that columns and dropdowns are consistent and aligned
  - Refactor disabled styling & logic in RuleStrategy
  - Create new RuleStrategyLabel component
nclairesays added a commit that referenced this issue Jan 28, 2021
@nclairesays
Refactor tooltips pt3 #671
6a110e1 
  - Remove unused code
  - Fix tooltip for parking baseline to only show up on tooltip icon (not label)
  - Rename variables and classname
  - Use jss theme colors when hovering on rows
  - Make RuleStrategy and RuleInput styles more consistent with each other
  - Restyled RuleStrategy so that columns and dropdowns are consistent and aligned
  - Refactor disabled styling & logic in RuleStrategy
  - Create new RuleStrategyLabel component
@nclairesays nclairesays mentioned this issue Jan 28, 2021
Merged
@entrotech entrotech added the refactor Release Note: Shows as System Update label Feb 13, 2021
@ExperimentsInHonesty ExperimentsInHonesty changed the title Refactor Tool tips Refactor: Tool tips Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jonathanko52 Jonathanko52

@nclairesays nclairesays

Labels
level: missing p-feature: Tool Tips priority: Could Have refactor Release Note: Shows as System Update role: front-end Front End Developer size: missing
Projects
P: TDM: project board
Archived in project
Milestone
CLOSED - 01 - Citizen Engagement / Ge...
Development

Successfully merging a pull request may close this issue.

671 refactor tooltips pt3 hackforla/tdm-calculator
8 participants
@entrotech @seenaiype @Jonathanko52 @nclairesays @KPHowley @VJ1285 @Rabia2219 @luca-navarrete