Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Nikhil to Leadership team in VRMs project #7901

Conversation

coding-yost
Copy link
Member

@coding-yost coding-yost commented Feb 7, 2025

Fixes #7878

What changes did you make?

  • Added Nikhil to Leadership team in VRMs project using code suggested in the issue

Why did you make the changes (we will use this info to test)?

  • They were suggested changes to be made in the issue

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

github-actions bot commented Feb 7, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b coding-yost-Update-Project-Profile-VRMS-Add-Nikhil-Trehan-#7878 gh-pages
git pull https://github.com/coding-yost/website.git Update-Project-Profile-VRMS-Add-Nikhil-Trehan-#7878

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 7, 2025
@Kle012 Kle012 self-requested a review February 8, 2025 01:35
Copy link
Member

@Kle012 Kle012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue. Looks good, but minor edit.

  • PR is made with the correct branch
  • Correct issue is linked
  • Correct member has been added
  • The change displayed correctly on broswer
  • No additional issues

What needs to be fixed:

  • Please check for CodeQL Alerts

@coding-yost
Copy link
Member Author

I have checked the CodeQL and found no alerts.

@Jaycelab Jaycelab requested review from Jaycelab and removed request for Jaycelab February 9, 2025 18:16
@coding-yost coding-yost requested a review from Kle012 February 9, 2025 18:34
Kle012
Kle012 previously approved these changes Feb 11, 2025
Copy link
Member

@Kle012 Kle012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Approved.
Thank you!

@trimakichan trimakichan self-requested a review February 11, 2025 18:32
@trimakichan
Copy link
Member

Review ETA: EOD 2/11/25
Availability: 10 AM - 4 PM PST, Mon-Fri

Copy link
Member

@trimakichan trimakichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coding-yost! Thank you for taking on this issue! You did great but there is a merge conflict below.

An issue related to yours (#7844) was merged before your PR, which caused a conflict. Please update your branch before we can proceed with merging your PR. Katiuska’s profile was added in the same lines as yours, so you just need to resolve the merge conflicts simply by clicking "Resolve Conflicts."

Things you did well:

  • The pull request is made from the correct branch. Good descriptive branch name!
  • The issue is linked correctly.
  • The changes are displayed correctly.
  • All links for Nikhil are working.
  • CodeQL alerts have been checked.

Thank you for your contribution! 🚀

@coding-yost coding-yost requested a review from Kle012 February 12, 2025 23:48
@LRenDO
Copy link
Member

LRenDO commented Feb 13, 2025

Hi @coding-yost!

Overall this looks great with the branching, visuals and the changes! One thing to note for the future, for the Why did you make the changes (we will use this info to test)? section we are looking for the reason why the issue was created to make the changes. This can usually be found in the Overview section of the original issue.

Thanks for contributing to the website!

@LRenDO LRenDO merged commit d8ed9a4 into hackforla:gh-pages Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: VRMS Add Nikhil Trehan
4 participants