-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Nikhil to Leadership team in VRMs project #7901
Added Nikhil to Leadership team in VRMs project #7901
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this issue. Looks good, but minor edit.
- PR is made with the correct branch
- Correct issue is linked
- Correct member has been added
- The change displayed correctly on broswer
- No additional issues
What needs to be fixed:
- Please check for CodeQL Alerts
I have checked the CodeQL and found no alerts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Approved.
Thank you!
Review ETA: EOD 2/11/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @coding-yost! Thank you for taking on this issue! You did great but there is a merge conflict below.
An issue related to yours (#7844) was merged before your PR, which caused a conflict. Please update your branch before we can proceed with merging your PR. Katiuska’s profile was added in the same lines as yours, so you just need to resolve the merge conflicts simply by clicking "Resolve Conflicts."
Things you did well:
- The pull request is made from the correct branch. Good descriptive branch name!
- The issue is linked correctly.
- The changes are displayed correctly.
- All links for Nikhil are working.
- CodeQL alerts have been checked.
Thank you for your contribution! 🚀
Hi @coding-yost! Overall this looks great with the branching, visuals and the changes! One thing to note for the future, for the Why did you make the changes (we will use this info to test)? section we are looking for the reason why the issue was created to make the changes. This can usually be found in the Overview section of the original issue. Thanks for contributing to the website! |
Fixes #7878
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied