-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[batch] hailctl batch submit
improvements and testing
#14805
base: main
Are you sure you want to change the base?
Conversation
d1c6edb
to
a2a376e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for pushing this over the line.
ce28d88
to
dedc203
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems well implemented and the test cases give me good confidence. My only minor concern is relying on a trailing '/' to decide whether something is a directory or not. If you can make me feel better about that, I'll happily 👍 . Oh, and I think a minor documentation improvement is possible too 😄
This was mostly implemented by @danking - I just tweaked the tests to not drool invalid current working directories. |
e897683
to
69f9781
Compare
69f9781
to
460103d
Compare
460103d
to
26fd310
Compare
hailctl batch submit
rewrite and various other fixes
hailctl batch submit
rewrite and various other fixeshailctl batch submit
improvements and testing
8bbf970
to
8642635
Compare
de906e5
to
21f27b2
Compare
CHANGELOG: Fix many issues, including (hail#14274), with hailctl batch submit introduced in 0.2.127. Fixes hail-is#14274, Replaces hail-is#14351 (authored by @jigold)
21f27b2
to
2785565
Compare
Potentially backwards incompatible
hailctl batch submit
rewrite and various other fixes. Originally authored by @danking in #14186 and later @jigold in #14351. It's had some tweaks since then as well as a liberal sprinkling of my biases.Issues resolved:
build.yaml
tests must not useexit 0
as it exits the test early.Always prefer
orjson
tojson
.The
--files
option has been changed significantly, allowing for special characters, environment variables and glob patterns inSRC
paths. DST paths may be absolute or relative to the job's working directory.Contra to @danking's approach, I'm not giving special dispensation to trailing slashes in DST paths. Instead I'm mimicking the behaviour of gnu tools
cp -RT SRC DST
.Fixes #14274
This change has low security impact.