-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add guide to dungeon hub races #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This json is not future prove. Since the races have different states they are in and adding in stuff later on gets comlicated. So make it instead of Map<String,ParkourJson> to Map<String,Map<String,ParkourJson>> and set the second layer to "Nothing, No return"
While this is true, I dont belive waypoints are useful for any of the races other than the no-return, nothing category so in my opinion it is fine as is |
How are they not useful? Sure, they're technically not necessary to do because you can get the talismans without them, but what if someone wants to complete all the objectives or something? |
There is no reason to do this, overcomplicating the data structure for a theoretical future feature that will likely never happen does not make any sense. Either way in the future if such a feature will be made the names can be suffixed or prefixed for example |
How exactly is it "overcomplicating" to make a perfectly logical data structure? Your argument is ridiculous. You're basically saying "we can do it in a hacky way later, so let's not use a logical structure in the first place". |
We have so many scuffed jsons. I don't want to handle another one. Also there is a defined future where this happens, since the feature requested all not 4 to complete the talisman. |
fixed :3 |
Could you separate the part "nothing" and "no_return" with a different symbol. E.g ":". Makes it easier to work with |
done <3 |
Can we please start with a template that contains the structure for all possible races? Then just fill in the currently existing data. |
The current format allows for it to work fine with new ones already, and I believe that adding these extra fields will just add clutter that is not needed |
done i think :3 |
data for dungeon hub races - needed for another pr