Fixes & Improvements: Hoppity Rework

[DavidArthurCole]

What

This PR involved an almost total rework of the chat detection that is inherent to the Hoppity "module":

Removes the 200ms delay that was added to Hoppity Compact in the early days when the number of messages was indeterminate (or, not always exactly 3).

See details and images below, but all "types" of rabbits found now consist of exactly three messages to spin them off, so the delay is no longer needed.

* The one exception to the "three-message rule" is when waypoint sharing is enabled, however this is still being accounted for separately and within the module itself.

---

This PR also addresses the "issue" that had been raised previously by hannibal (see here) about using LorenzChatEvent() to fake messages for:

• Side Dish Eggs
• All-time Milestone "Eggs"
• Factory Milestone "Eggs"
• Stray Rabbits that also count as "real" rabbits (Fish the Rabbit and El Dorado)

Instead of doing that, it's using an event registry now for EggFoundEvent(), and leaving it up to the modules to determine what to do with that. This was most prevalent for the Compact Hoppity stuff.

---

Images

Meal (Normal):

Bought:

Side Dish+ (the same logic here applies to Factory and Shop milestones, since they all use a manually-created chat event for type declaration):

Strays (again, contrived third message, but - also the messageCount can be ignored):

Changelog Fixes

• Fixed an issue where Fish the Rabbit and El Dorado did not have compacted chat messages. - Daveed

Changelog Improvements

• Improved the responsiveness of Hoppity Chat Compacting. - Daveed

Changelog Technical Details

• Removed the use of LorenzChatEvent() for 'manually' adding data to Hoppity Chat Compact. - Daveed
  • Now uses EggFoundEvent().

[DavidArthurCole]

So I wasn't actually accounting for waypoint sharing in the "every hoppity message consists of 3" - but that's fixed now, so...

[DavidArthurCole]

Nvm now purchased rabbits broke, which is dope considering I didn't touch those at all 🔥

[DavidArthurCole]

I'm realizing this PR's scope creeped rather massively as I found more and more small issues with Hoppity's, but uhhh yeah there are now fixes & improvements. Still testing a couple things out before I'm 100% confident on some of the assumptions made - need next hoppity to come around to verify that event firing won't overlap.