Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enchanted Clock Reminders #3051

Merged
merged 34 commits into from
Jan 9, 2025

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Dec 12, 2024

Dependencies

What

https://discord.com/channels/997079228510117908/1316578743095005224
Adds optional reminder(s) when enchanted clock boosts become available.

Changelog New Features

  • Added reminders for Enchanted Clock boosts. - Daveed

@hannibal002 hannibal002 added this to the Version 0.29 milestone Dec 13, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 17, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 17, 2024
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Detekt Has detekt problem label Dec 17, 2024
Copy link

One or more Detekt Failures were detected:

  • SimpleTimeMark.kt#L14: Class 'SimpleTimeMark' with '20' functions detected. Defined threshold inside classes is set to '20'

@DavidArthurCole
Copy link
Contributor Author

I could've sworn I suppressed that during the merge... whatever, yap away, bot

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 17, 2024
@DavidArthurCole
Copy link
Contributor Author

Kinda forgot I had developed this, as it doesn't appear to be working atm. The baseline setup for loading the clock stuff should be good, but the reminders might be bugged.

@DavidArthurCole
Copy link
Contributor Author

image

@jani270 jani270 added the Soon This Pull Request will be merged within the next couple of betas label Jan 4, 2025
@hannibal002 hannibal002 self-requested a review January 8, 2025 16:55
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after opening the clock or after enabling one boost, the availableAt value in the config is still null for every element. This cant work

Search config for SkyHanni 1.2.0
configSearchTerm: 'enchantedclockboosts'
classSearchTerm: <all>

Found 1 config elements:
profileSpecific.enchantedClockBoosts java.util.LinkedHashMap = {§bMinions=Status(state=§eProblem, availableAt=null, warned=false), §6Chocolate Factory=Status(state=§aReady, availableAt=null, warned=false), §dPet Training=Status(state=§eProblem, availableAt=null, warned=false), §bPet Sitter=Status(state=§eProblem, availableAt=null, warned=false), §eAging Items=Status(state=§aReady, availableAt=null, warned=false), §6Forge=Status(state=§eProblem, availableAt=null, warned=false)}

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Conflicts have been resolved! 🎉

@DavidArthurCole
Copy link
Contributor Author

after opening the clock or after enabling one boost, the availableAt value in the config is still null for every element. This cant work

That would be because in your cleanup commits, you edited core functionality of the lookups between the simple and repo-loaded enum classes, and they would, post that, never succeed, so no values would be updated.

Search config for SkyHanni 1.2.0
configSearchTerm: 'enchantedclockboosts'
classSearchTerm: <all>

Found 1 config elements:
profileSpecific.enchantedClockBoosts java.util.EnumMap = {§bMinions=Status(state=§cCharging, availableAt=2025-01-10T21:28:20.158Z, warned=false), §6Chocolate Factory=Status(state=§cCharging, availableAt=2025-01-09T12:28:17.030Z, warned=false), §dPet Training=Status(state=§eProblem, availableAt=null, warned=false), §bPet Sitter=Status(state=§eProblem, availableAt=null, warned=false), §eAging Items=Status(state=§aReady, availableAt=null, warned=false), §6Forge=Status(state=§cCharging, availableAt=2025-01-09T13:28:17.030Z, warned=false)}

@github-actions github-actions bot added the Detekt Has detekt problem label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

One or more Detekt Failures were detected:

  • EnchantedClockHelper.kt#L200: The loop contains more than one break or continue statement. The code should be refactored to increase readability.

@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 8, 2025
@hannibal002
Copy link
Owner

sorry for breakin things :(

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafik

@hannibal002
Copy link
Owner

@jani270 i hope you are happy with this fix

@hannibal002 hannibal002 enabled auto-merge (squash) January 9, 2025 00:14
@hannibal002 hannibal002 merged commit 7fd3e99 into hannibal002:beta Jan 9, 2025
6 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jan 9, 2025
@DavidArthurCole DavidArthurCole deleted the EnchClockWarnings branch January 9, 2025 00:23
@jani270
Copy link
Collaborator

jani270 commented Jan 9, 2025

crazy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants