-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Enchanted Clock Reminders #3051
Feature: Enchanted Clock Reminders #3051
Conversation
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
One or more Detekt Failures were detected:
|
I could've sworn I suppressed that during the merge... whatever, yap away, bot |
Kinda forgot I had developed this, as it doesn't appear to be working atm. The baseline setup for loading the clock stuff should be good, but the reminders might be bugged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after opening the clock or after enabling one boost, the availableAt
value in the config is still null
for every element. This cant work
Search config for SkyHanni 1.2.0
configSearchTerm: 'enchantedclockboosts'
classSearchTerm: <all>
Found 1 config elements:
profileSpecific.enchantedClockBoosts java.util.LinkedHashMap = {§bMinions=Status(state=§eProblem, availableAt=null, warned=false), §6Chocolate Factory=Status(state=§aReady, availableAt=null, warned=false), §dPet Training=Status(state=§eProblem, availableAt=null, warned=false), §bPet Sitter=Status(state=§eProblem, availableAt=null, warned=false), §eAging Items=Status(state=§aReady, availableAt=null, warned=false), §6Forge=Status(state=§eProblem, availableAt=null, warned=false)}
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
That would be because in your cleanup commits, you edited core functionality of the lookups between the simple and repo-loaded enum classes, and they would, post that, never succeed, so no values would be updated.
|
One or more Detekt Failures were detected:
|
sorry for breakin things :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jani270 i hope you are happy with this fix |
crazy |
Dependencies
What
https://discord.com/channels/997079228510117908/1316578743095005224
Adds optional reminder(s) when enchanted clock boosts become available.
Changelog New Features