Feature: Add Trinity helper #3462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Wrong Title/Changelog
|
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
Thunderblade73
suggested changes
Feb 19, 2025
src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonTrinityHelper.kt
Outdated
Show resolved
Hide resolved
1 Detekt Failure was detected:
|
|
I got a 5 puzzle room on M5 just now and no Trinity. I still think this feature is helpful for people desperate for contact, but maybe we should make it opt-in? Also accepting suggestions on another sound to play, I copied the code from ultra rare books and the dragon sound is the same as dungeon start lol |
2 Detekt Failures were detected:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a notification when user joins a dungeons with 5 puzzles, as this dungeons have a high chance of containing rare 1x1 rooms, like the one Trinity spawns on. There is no official info on Trinity spawn chances, but flex posts and videos I watched, all reinforce the idea of 5 puzzles == Trinity.
Changelog New Features