Improvement: Pet Display V2 #3475
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.kt
Comment on lines
+29
to
+30
| val nameRender = Renderable.string(displayName, color = rarityColor.toColor()) | ||
| val circle = Renderable.CircularRenderable( |
There was a problem hiding this comment.
add a horizontalAlign = horizontalAlign.CENTER for both here. (Makes it look better)
There was a problem hiding this comment.
the name render isn't staying there permanently - it's gonna be a lot more flushed out, that was mainly there when the circles weren't appearing so it was clear something was rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Lorem ipsum, I'll write something here later.
Images
Changelog Improvements