Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defaults to be more up-to-date #4

Merged
merged 3 commits into from
Dec 28, 2020

Conversation

marknet15
Copy link
Contributor

Overview

This role is really useful but some of the defaults are a little outdated so I've updated them to be more up-to-date such as the versions installed by default of homebridge and nodejs.

Copy link
Owner

@hannseman hannseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks! 👍

@hannseman hannseman merged commit b950c68 into hannseman:master Dec 28, 2020
@marknet15
Copy link
Contributor Author

@hannseman I'm just taking a look at the CI as it seems to have failed following the merge on the pretasks

CRITICAL Failed to pre-validate.
{'driver': [{'name': ['unallowed value docker']}], 'lint': ['must be of string type']}
The command "molecule --debug test" exited with 1.

@marknet15
Copy link
Contributor Author

Think it's the same issue as reported here:
ansible/molecule#2891

Raised a followup PR:
#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants