-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Commands): resolve mentions into objects #198
Conversation
Does this also resolve ID's into objects? |
const mentionToRegex: MentionToRegex = {
user: /<@!?(\d{17,19})>|(\d{17,19})/,
role: /<@&(\d{17,19})>|(\d{17,19})/,
channel: /<#(\d{17,19})>|(\d{17,19})/
} These are the regex's |
I hate lint! |
@Helloyunho @grian32 and @DjDeveloperr this is now ready for review I added a few comments to everything and I hope that explain enough. |
There was a flaw in the code where it wouldn't solve that properly. Now it does tho :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've also been able to test locally with my bot and it works as expected, good job!
thanks :3 Wasn't sure if the mocking was accurate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! let's wait for dj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
About
this should close #190
Feedback is appreciated
cc @DjDeveloperr and @grian32
Status