Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onMissingArgs method to Command #199

Merged
merged 5 commits into from
Jul 17, 2021
Merged

Add onMissingArgs method to Command #199

merged 5 commits into from
Jul 17, 2021

Conversation

grian32
Copy link
Contributor

@grian32 grian32 commented Jul 16, 2021

About

Closes #182
Introduces a onMissingArgs method to Command and does the appropriate changes to make it work, this allows for more granular missing arg responses

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

DjDeveloperr
DjDeveloperr approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@DjDeveloperr DjDeveloperr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice!

@DjDeveloperr DjDeveloperr merged commit f8b553d into harmonyland:main Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DjDeveloperr DjDeveloperr DjDeveloperr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] onMissingArgs handler in Command
2 participants
@grian32 @DjDeveloperr