Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Command Events #221

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Application Command Events #221

merged 3 commits into from
Sep 2, 2021

Conversation

Loliticos
Copy link
Contributor

About

The events applicationCommandCreate, applicationCommandUpdate and applicationCommandDelete were removed for bots. discord/discord-api-docs#3691

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

@DjDeveloperr
Copy link
Member

Please fix lint errors before we can merge

@Loliticos
Copy link
Contributor Author

Please fix lint errors before we can merge

Done, LMK if anything else

@MierenManz
Copy link
Contributor

Isn't this technically a breaking Change if we remove these?

@Loliticos
Copy link
Contributor Author

Isn't this technically a breaking Change if we remove these?

Not really, these events weren't emitted for bots. So they never really "worked"

@Helloyunho
Copy link
Member

Isn't this technically a breaking Change if we remove these?

Not really, these events weren't emitted for bots. So they never really "worked"

Discord is weird isn't it

Helloyunho
Helloyunho approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AkiaCode
Copy link
Member

AkiaCode commented Sep 2, 2021

lgtm

@DjDeveloperr DjDeveloperr merged commit 9600dbb into harmonyland:main Sep 2, 2021
@MierenManz
Copy link
Contributor

Isn't this technically a breaking Change if we remove these?

Not really, these events weren't emitted for bots. So they never really "worked"

Oh okay yeah then it is fine. Already wondered why this would be a change without technically breaking stuff

@Loliticos Loliticos deleted the command-events branch September 3, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helloyunho Helloyunho Helloyunho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Loliticos @DjDeveloperr @MierenManz @Helloyunho @AkiaCode