Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(role): Role icons #251

Merged
merged 7 commits into from
Nov 3, 2021
Merged

Conversation

invalidCards
Copy link
Contributor

About

Adds the ability to fetch and upload role icons. Completely untested (apart from the fact that role.roleIcon() correctly returns undefined if there is no icon and that trying to update a role with a unicode emoji gives a boost error on unboosted guilds) so if you have a dev server that's boosted 7+ times go right ahead

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Helloyunho Helloyunho added the hacktoberfest-accepted Hacktoberfest 2021 label Oct 4, 2021
@DjDeveloperr DjDeveloperr linked an issue Oct 25, 2021 that may be closed by this pull request
Copy link
Member

@DjDeveloperr DjDeveloperr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge upstream main branch to fix canary CI failing.

* feat: autocomplete support

* chore: update redis
@DjDeveloperr DjDeveloperr merged commit 159cb78 into harmonyland:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest 2021
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Implement role icon fetching and setting
3 participants