Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicon and container width #512

Merged

Conversation

tinykite
Copy link
Contributor

@tinykite tinykite commented Mar 5, 2024

What this does

Updates favicon.ico for Safari with additional whitespace around the logo. Additionally constraints the width of the page description on the LIL homepage with a max-width declaration that constraints the width, using ch units — which is the approximate width of a 0. (For situations where we want to constrain the width of an element for readability purposes, it's very useful!)

Closes Eng-683 and Eng-686.

Screenshots

Screenshot 2024-03-05 at 10 10 19 AM
The updated favicon is in the left menu — the existing apple touch icon shows up in the icon grid to the right.

Screenshot 2024-03-05 at 10 08 47 AM
A mobile-sized viewport showing the header splash content region

Screenshot 2024-03-05 at 10 07 53 AM
A desktop-sized viewport showing the header splash content region. The content declaratively always breaks after the same number of characters, regardless of viewport width.

How to Test

I discovered in the testing of this fix that Safari caches favicons, which definitely caused me a fair amount of confusion. However, these are the steps that can be taken to refresh your favicons:

  • Quit Safari
  • Switch to the finder and use CMD-Shift-G to bring up a contextual "Go To" menu.
  • Navigate to ~/Library/Safari/Favicon Cache/ and delete everything in the Favicon Cache folder.
  • Open Safari again — the favicons should be cleared. If the LIL website is in your favorites, you may need to click on the apple touch icon in the favorites icon grid or the favicon itself in the sidebar to refresh the icon. If, for some bizarre reason this does not work, you may need to try to quit out of Safari and/or hard refresh in an incognito window until you see the icons cleared again. 🙃

@tinykite tinykite marked this pull request as ready for review March 5, 2024 16:24
@tinykite tinykite requested a review from bensteinberg March 5, 2024 16:25
@tinykite tinykite merged commit 3739034 into harvard-lil:rebrand Mar 5, 2024
1 check passed
@tinykite tinykite deleted the update-favicon-and-container-width branch March 5, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants