Update favicon and container width #512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Updates
favicon.ico
for Safari with additional whitespace around the logo. Additionally constraints the width of the page description on the LIL homepage with amax-width
declaration that constraints the width, using ch units — which is the approximate width of a 0. (For situations where we want to constrain the width of an element for readability purposes, it's very useful!)Closes Eng-683 and Eng-686.
Screenshots
The updated favicon is in the left menu — the existing apple touch icon shows up in the icon grid to the right.
A mobile-sized viewport showing the header splash content region
A desktop-sized viewport showing the header splash content region. The content declaratively always breaks after the same number of characters, regardless of viewport width.
How to Test
I discovered in the testing of this fix that Safari caches favicons, which definitely caused me a fair amount of confusion. However, these are the steps that can be taken to refresh your favicons:
CMD-Shift-G
to bring up a contextual "Go To" menu.~/Library/Safari/Favicon Cache/
and delete everything in the Favicon Cache folder.