-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: initial CRT support #45
Conversation
2548bfa
to
d102faa
Compare
Minor: If security scans are the only reason we need this, we can ask for @dduzgun-security 's help provisioning a tighter-scoped token like we did in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but overall this looks great to me. Thank you for all the work on this and attention to detail porting over existing patterns 🙏🏻
181b793
to
e0eafaf
Compare
Co-authored-by: Deniz Onur Duzgun <[email protected]>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
1 similar comment
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Description
Adds CRT support for
consul-aws
based on the same setup used inconsul-dataplane
. It still requires some setup on the rel-eng side, which is in process.I will also assign someone in rel-eng to review once they are assigned to the help desk ticket.
Notes
Since CRT handles most of the build and release process, I gutted the Makefile and associated build scripts.
Example
version
output:> consul-aws version consul-aws 0.1.3-dev Git Commit: 72245af+CHANGES
Required for this PR
Future PRs