Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: initial CRT support #45

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

DanStough
Copy link
Contributor

@DanStough DanStough commented Apr 10, 2024

Description

Adds CRT support for consul-aws based on the same setup used in consul-dataplane. It still requires some setup on the rel-eng side, which is in process.

I will also assign someone in rel-eng to review once they are assigned to the help desk ticket.

Notes

Since CRT handles most of the build and release process, I gutted the Makefile and associated build scripts.

Example version output:

> consul-aws version
consul-aws 0.1.3-dev
Git Commit: 72245af+CHANGES

Required for this PR

  • HASHIBOT_PRODSEC_GITHUB_TOKEN (Used for the security scanner)

Future PRs

  • More actions for testing.
  • Documentation for running the integration tests.

@DanStough DanStough added the pr/no-changelog Used to indicated there is no user-facing changelog for a PR label Apr 10, 2024
@DanStough DanStough requested a review from zalimeni April 10, 2024 20:41
@DanStough DanStough added pr/no-changelog Used to indicated there is no user-facing changelog for a PR and removed pr/no-changelog Used to indicated there is no user-facing changelog for a PR labels Apr 10, 2024
@DanStough DanStough force-pushed the dans/NET-7888/crt-and-other-github-actions branch from 2548bfa to d102faa Compare April 10, 2024 21:06
@zalimeni
Copy link
Member

ELEVATED_GITHUB_TOKEN (Used for the security scanner)

Minor: If security scans are the only reason we need this, we can ask for @dduzgun-security 's help provisioning a tighter-scoped token like we did in consul

Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but overall this looks great to me. Thank you for all the work on this and attention to detail porting over existing patterns 🙏🏻

@DanStough DanStough force-pushed the dans/NET-7888/crt-and-other-github-actions branch from 181b793 to e0eafaf Compare April 11, 2024 16:39
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

1 similar comment
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@dduzgun-security dduzgun-security self-requested a review April 19, 2024 17:54
@DanStough DanStough merged commit 9919ff8 into main Apr 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog Used to indicated there is no user-facing changelog for a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants