tfsdk: Update attribute Required/Optional/Computed diagnostic handlin…

…g after rebase
hashicorp · Sep 1, 2021 · 9517ae4 · 9517ae4
1 parent 0e1a0c0
commit 9517ae4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/tfsdk/attribute.go b/tfsdk/attribute.go
@@ -247,12 +247,11 @@ func (a Attribute) validate(ctx context.Context, req ValidateAttributeRequest, r
 	}
 
 	if !a.Required && !a.Optional && !a.Computed {
-		resp.Diagnostics = append(resp.Diagnostics, &tfprotov6.Diagnostic{
-			Severity:  tfprotov6.DiagnosticSeverityError,
-			Summary:   "Invalid Attribute Definition",
-			Detail:    "Attribute missing Required, Optional, or Computed definition. This is always a problem with the provider and should be reported to the provider developer.",
-			Attribute: req.AttributePath,
-		})
+		resp.Diagnostics.AddAttributeError(
+			req.AttributePath,
+			"Invalid Attribute Definition",
+			"Attribute missing Required, Optional, or Computed definition. This is always a problem with the provider and should be reported to the provider developer.",
+		)
 
 		return
 	}

diff --git a/tfsdk/attribute_test.go b/tfsdk/attribute_test.go
@@ -777,13 +777,12 @@ func TestAttributeValidate(t *testing.T) {
 				},
 			},
 			resp: ValidateAttributeResponse{
-				Diagnostics: []*tfprotov6.Diagnostic{
-					{
-						Severity:  tfprotov6.DiagnosticSeverityError,
-						Summary:   "Invalid Attribute Definition",
-						Detail:    "Attribute missing Required, Optional, or Computed definition. This is always a problem with the provider and should be reported to the provider developer.",
-						Attribute: tftypes.NewAttributePath().WithAttributeName("test"),
-					},
+				Diagnostics: diag.Diagnostics{
+					diag.NewAttributeErrorDiagnostic(
+						tftypes.NewAttributePath().WithAttributeName("test"),
+						"Invalid Attribute Definition",
+						"Attribute missing Required, Optional, or Computed definition. This is always a problem with the provider and should be reported to the provider developer.",
+					),
 				},
 			},
 		},