Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ResourceWithModifyPlan interface #90

Merged
merged 9 commits into from
Aug 4, 2021
Merged

Implement ResourceWithModifyPlan interface #90

merged 9 commits into from
Aug 4, 2021

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Jul 29, 2021 •
edited
Loading

Epic: #34

Design doc: #64

Plan modification functionality has two parts:

  1. The ResourceWithModifyPlan interface (this PR)
  2. schema.Attribute.PlanModifiers (future PR)

This PR adds the ResourceWithModifyPlan interface, allowing resources to define an optional ModifyPlan function.

type ResourceWithModifyPlan interface {
 	Resource
 
 	ModifyPlan(context.Context, ModifyResourcePlanRequest, *ModifyResourcePlanResponse)
}

kmoe added a commit that referenced this pull request Aug 2, 2021
@kmoe
add changelog for #90
6f0e459
@kmoe kmoe marked this pull request as ready for review August 2, 2021 14:25
@kmoe kmoe requested a review from a team August 2, 2021 14:25
@bflad bflad self-assigned this Aug 2, 2021
bflad
bflad approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking good to me. Just some minor feedback! 🚀

@bflad bflad assigned kmoe and unassigned bflad Aug 2, 2021
@kmoe kmoe force-pushed the katy-plan-customisation branch from e265e73 to 85a4f3e Compare August 4, 2021 16:29
@kmoe kmoe merged commit b9482f3 into main Aug 4, 2021
@kmoe kmoe deleted the katy-plan-customisation branch August 4, 2021 16:35
@github-actions
Copy link

github-actions bot commented Sep 4, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

@bflad bflad bflad approved these changes

Assignees

@kmoe kmoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmoe @paddycarver @bflad