Merge pull request #2208 from quixoticmonk/fix/datasources-pagination

fix: pagination on plural datasources
hashicorp · Feb 18, 2025 · ed8362f · ed8362f
2 parents 24f2b4e + 9f319d9
commit ed8362f
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/internal/service/cloudcontrol/list.go b/internal/service/cloudcontrol/list.go
@@ -18,6 +18,7 @@ func ListResourcesByTypeName(ctx context.Context, conn *cloudcontrol.Client, rol
 		"cfTypeName": typeName,
 	})
 
+	var resourceDescriptions []types.ResourceDescription
 	input := &cloudcontrol.ListResourcesInput{
 		TypeName: aws.String(typeName),
 	}
@@ -26,15 +27,19 @@ func ListResourcesByTypeName(ctx context.Context, conn *cloudcontrol.Client, rol
 		input.RoleArn = aws.String(roleARN)
 	}
 
-	output, err := conn.ListResources(ctx, input)
+	paginator := cloudcontrol.NewListResourcesPaginator(conn, input)
+	for paginator.HasMorePages() {
+		page, err := paginator.NextPage(ctx)
+		if err != nil {
+			return nil, err
+		}
 
-	if err != nil {
-		return nil, err
+		resourceDescriptions = append(resourceDescriptions, page.ResourceDescriptions...)
 	}
 
-	if output == nil {
+	if len(resourceDescriptions) == 0 {
 		return nil, &tfresource.NotFoundError{Message: "Empty result"}
 	}
 
-	return output.ResourceDescriptions, nil
+	return resourceDescriptions, nil
 }