Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Clojure 1.9+ #227

Closed
4 of 5 tasks
jaidetree opened this issue Feb 12, 2019 · 9 comments
Closed
4 of 5 tasks

Support Clojure 1.9+ #227

jaidetree opened this issue Feb 12, 2019 · 9 comments
Assignees
Labels

Comments

@jaidetree
Copy link
Contributor

jaidetree commented Feb 12, 2019

Perun cannot run entirely in Clojure 1.9+. This is due to a dependency on sitemap with a ns form that doesn't conform to the updated spec. The fix for sitemap was merged into master but there are a few steps involved before it can be updated in perun.

  • Patch sitemap to pass Clojure 1.9+ validation
  • Merged sitemap patch into master
  • Release new version of sitemap
  • Update sitemap dependency in perun deps. (waiting for Fix Tests & Bump (most) Deps #224)
  • Release new version of perun
@allentiak
Copy link
Contributor

allentiak commented Feb 12, 2019 via email

@jaidetree
Copy link
Contributor Author

What needs to be done to release the next version of sitemap? No rush or anything 😄, just want to understand the status of that project in relation to perun.

@podviaznikov
Copy link
Member

released sitemap 0.4.0.
let me know if anything is needed there https://clojars.org/sitemap

@allentiak
Copy link
Contributor

@eccentric-j
Once closed, #224 will take care of the third item.
I added a fourth item to the list for the released of an updated perun afterwards.

@jaidetree
Copy link
Contributor Author

Great, thanks Podviaznikov. Added a note in the code review on #224 to bump sitemap to 0.4.0.

@allentiak
Copy link
Contributor

allentiak commented May 13, 2019

@eccentric-j #224 has been merged

@allentiak allentiak assigned allentiak and unassigned podviaznikov May 13, 2019
@jaidetree
Copy link
Contributor Author

@allentiak Great, thanks.

@podviaznikov @allentiak What's next to be able to release the next version of perun?

@allentiak
Copy link
Contributor

allentiak commented May 14, 2019 via email

@allentiak
Copy link
Contributor

I have tested perun with Clojure 1.10.1, and it works fine. (I'm closing this.)

(The only thing left to do would be the release, but I think we should first discuss what we would like to see there.)

allentiak added a commit that referenced this issue Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants