This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Install libncurses5 and libtinfo5 for ghc < 8.3 on Linux #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't correct yet: - we should properly compare version strings - we should check for ubuntu-22.04 (or later), not just linux.
This works only on ubuntu-20.04 but I do not know how to check for this a priori.
andreasabel
force-pushed
the
libcurses5-for-ghc-8.2
branch
from
16be8c0 to
03eec5d
Compare
|
Yay, CI is green! |
andreasabel
force-pushed
the
libcurses5-for-ghc-8.2
branch
from
d9b2612 to
22d5cc8
Compare
andreasabel
changed the title
andreasabel
force-pushed
the
libcurses5-for-ghc-8.2
branch
from
22d5cc8 to
2d44f29
Compare
|
@hazelweakly I suppose this can be released now as 2.0.3, helping with the |
|
It seems that this fix would prevent further confusion of users using |
|
Published as v2.0.3 v2.0 v2 |
andreasabel
added
the
re: prerequisites
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #135: Install
libncurses5andlibtinfo5forghc < 8.3onLinuxThis isn't correct yet:
compare-versionspackage)ubuntu-20.04, not just linux.I have asked a stackoverflow questions on how to do this: https://stackoverflow.com/questions/74736286/how-can-i-check-in-a-github-action-whether-i-am-running-in-ubuntu-20-04-or-ub
@hazelweakly : I would like your feedback and help, because I am an absolute JavaScript beginner.
Also, I wonder whether an existing version comparison (for(UPDATE: also usingstack) is correct, see my comment.compareVersionshere.)