Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftovers from cmm-options fix #6377

Closed
phadej opened this issue Nov 27, 2019 · 2 comments
Closed

Leftovers from cmm-options fix #6377

phadej opened this issue Nov 27, 2019 · 2 comments

Comments

@phadej
Copy link
Collaborator

phadej commented Nov 27, 2019

#6033
cc @angerman


Things that work now (i.e. that I (@hvr) tested manually; these should be turned into testsuite tests long-term):

  • cmm-sources and asm-sources are compiled (in a separate phase like c-sources are) and the resulting object files are linked into the respective component (i.e. like c-sources)
  • cabal sdist properly includes cmm-sources and asm-sources in the src-dist
  • cmm-options are passed (directly) to GHC when compiling cmm-sources
  • asm-options are passed (via -opta) to GHC when compiling asm-sources files
  • ghc-options are NOT passed to compilation of cmm-sources/asm-sources

@23Skidoo:

If I have both preprocessor-generated asm-sources and cmm-sources, won't this add the union of these to the LBI's asmSources?

Actually, this probably will break if I have any preprocessor-generated C files at all.


TODO: forward port b7cd00b to 3.0+

@23Skidoo
Copy link
Member

I left some comments in #6033, were they addressed in the version that got merged to master?

@phadej
Copy link
Collaborator Author

phadej commented Nov 28, 2019

Edited the description to include preprocessor-generated issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants