[API-898] Make SqlRow support [] operator
#478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly an enhancement for easier access for columns in the row. Now, the `SqlRow` implements the `__getitem__` magic method. Implementation of the method simply performs a type check and calls `get_object_with_index` if the type of the passed parameter is an integer type. For any other type, it calls `get_object`. Hence, it will throw for any other type than `int` or `str`. Also, put a piece of information about this new way to the documentation & code samples.
srknzl
approved these changes
Sep 22, 2021
mdumandag
changed the title
SqlRow support [] operatorSqlRow support [] operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly an enhancement for easier access for columns in the row.
Now, the
SqlRowimplements the__getitem__magic method.Implementation of the method simply performs a type check and calls
get_object_with_indexif the type of the passed parameter is aninteger type. For any other type, it calls
get_object. Hence,it will throw for any other type than
intorstr.Also, put a piece of information about this new way to the documentation
& code samples.