Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unused crates #160

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Removes unused crates #160

merged 2 commits into from
Nov 3, 2023

Conversation

xfbs
Copy link
Contributor

@xfbs xfbs commented Nov 3, 2023

I saw that there are some crates that are not used (thanks to cargo udeps), this PR removes them.

Food for thought: maybe we want to add a CI stage for running cargo udeps?

@xfbs xfbs self-assigned this Nov 3, 2023
@xfbs xfbs requested a review from mara-schulke November 3, 2023 08:35
@xfbs xfbs added complexity::low Issues or ideas with a low implementation cost component::cli Everything related to the buffrs cli priority::low Please dont work on this if you can contribute something with a higher priority type::fix labels Nov 3, 2023
@mara-schulke
Copy link
Contributor

Yes feel free to do so! I would want to keep CI runtime as low as possible though.

@mara-schulke mara-schulke merged commit 95e27a7 into main Nov 3, 2023
@mara-schulke mara-schulke deleted the pe/unused-crates branch November 3, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mara-schulke mara-schulke mara-schulke approved these changes

Assignees

@xfbs xfbs

Labels
complexity::low Issues or ideas with a low implementation cost component::cli Everything related to the buffrs cli priority::low Please dont work on this if you can contribute something with a higher priority type::fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xfbs @mara-schulke