Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix support tracking branch #172

Closed
wants to merge 23 commits into from
Closed

Nix support tracking branch #172

wants to merge 23 commits into from

Conversation

j-baker
Copy link
Contributor

@j-baker j-baker commented Nov 21, 2023

No description provided.

@j-baker j-baker changed the title Nix support tracking build Nix support tracking branch Nov 21, 2023
@mara-schulke mara-schulke added priority::high Urgent change or idea, please review quickly integration Changes and ideas related to integrating buffrs with 3rd-party software or tools complexity::high Issues or ideas that are highly complex. require discussion and may affect backwards compatibility type::epic An epic change. This is going to make a big difference to buffrs as a product. labels Dec 6, 2023
@mara-schulke mara-schulke added this to the Stabilization milestone Dec 6, 2023
@qsantos qsantos mentioned this pull request Jan 5, 2024
Merged
@j-baker
Copy link
Contributor Author

j-baker commented Jan 5, 2024

Known bug - at present this does not handle dependencies on crates that themselves use buffrs, when utilised by the Rust integration. Only works with local proto.tomls.

I think one solution would be to revamp the idea of the cache to simply directly reference Nix store paths. And then we specifically interact with Crane's Cargo registry when setting things up for buffrs, looking for proto.toml files in all the downloaded crates.

@mara-schulke
Copy link
Contributor

@j-baker we could also remove the feature from the rust integration to download dependencies

I think this causes a lot of trouble for many people unfortunately

@mara-schulke
Copy link
Contributor

Also have we verified what the behavior is when crate x depends on buffrs package x and is then published?

Do we bundle the protos inside? I don't think so, my worries here would be that the build of crate x runs a buffrs install through the rust integration. This only works if the consumer has access to the proto repos / registry that the crate uses.. (or am I having a wrong guess here?)

@mara-schulke
Copy link
Contributor

Hi @j-baker this branch is a whole 194 commits behind main, is there some way we could backport this or get this merged soon?

@mara-schulke mara-schulke mentioned this pull request Feb 21, 2024
Merged
@mara-schulke
Copy link
Contributor

Closed because main has Nix support since 0.8 (which was based on the work done in this branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@j-baker j-baker

Labels
complexity::high Issues or ideas that are highly complex. require discussion and may affect backwards compatibility integration Changes and ideas related to integrating buffrs with 3rd-party software or tools priority::high Urgent change or idea, please review quickly type::epic An epic change. This is going to make a big difference to buffrs as a product.
Projects
Buffrs
Status: Done
Milestone
Stabilization
Development

Successfully merging this pull request may close these issues.
2 participants
@j-baker @mara-schulke