Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store package in cache on first download #260

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Store package in cache on first download #260

merged 4 commits into from
Jul 9, 2024

Conversation

fredrb
Copy link
Contributor

@fredrb fredrb commented Jul 8, 2024

Fixes #258

Allow packages to be stored in the cache on their first download by calculating the hash as soon as they are fetched.

@fredrb fredrb force-pushed the fred/fix-cache-bug branch from aa64a3a to 2cbeead Compare July 8, 2024 07:39
Copy link
Contributor

@mara-schulke mara-schulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except the one fn sig!

@fredrb fredrb force-pushed the fred/fix-cache-bug branch from 27ad19f to 3cdddfb Compare July 9, 2024 07:25
@fredrb fredrb merged commit f8bd7e4 into main Jul 9, 2024
7 checks passed
@fredrb fredrb deleted the fred/fix-cache-bug branch July 9, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache is not populated on first install
2 participants