-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python code generation #72
Conversation
Do we need to modify: https://helsing-ai.github.io/buffrs/integrations/cargo.html
As Language::Rust has been removed from the enum, and lib.rs by default uses Tonic |
Yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some things on the generation code, otherwise it looks good to me
Co-authored-by: Mara Schulke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nits, let's merge once they are resolved :)
Co-authored-by: Mara Schulke <[email protected]>
Co-authored-by: Mara Schulke <[email protected]>
My first rust contribution, this code:
--lang python
to be passed tobuffrs generate
as well as an optional--out-dir
argument which can redirect where the generated python code is exported to.--proto-path
to give finer control over the location of generated code