Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suma2text.js): adding an if to check if process exists to emit a warning #30

Merged

Conversation

JoaoRocha97
Copy link
Contributor

Adding an if to check if process exists to emit a warning on customizing a validator on a
typescript project

fix #28

…a warning

Adding an `if` to check if process exists to emit a warning on customizing a validator on a
typescript project

fix herbsjs#28
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #30 (e51fb5c) into master (7052836) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   98.03%   98.07%   +0.03%     
==========================================
  Files           5        5              
  Lines          51       52       +1     
==========================================
+ Hits           50       51       +1     
  Misses          1        1              
Impacted Files Coverage Δ
src/suma2Text.js 97.91% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2251c...e51fb5c. Read the comment docs.

@jhomarolo jhomarolo merged commit 43f58fb into herbsjs:master Feb 15, 2022
@jhomarolo
Copy link
Contributor

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When usend on typescript process.emitWarning throws error
2 participants