Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Heroku CI, implementing the Testpack API by:
bin/compile
tolib/compile_common.sh
.lib/compile_common.sh
instead ofbin/compile
.process_env_files
function to take a "scope" parameter. This allows setting thelaunch
scope when invoked from thebin/compile
script (retaining the current behavior), and thebuild
scope when invoked from the newbin/test-compile
script (sobin/test
can use the build-onlysdk
andnuget
layers).BUILD_CONFIGURATION
orMSBUILD_VERBOSITY_LEVEL
env vars are set inbin/test
, and passing their values to thedotnet test
command if present. While it's somewhat unlikely that users will configure these in their Heroku CI environment, thebin/test-compile
script will detect these values (as they're support by the CNB), so we should support them inbin/test
as well.It's worth noting that the
bin/test-compile
script will invoke the CNB'sbin/build
executable and publishes the app (likebin/compile
), which is not necessary to runbin/test
. We may want to add logic to the CNB that allows skipping thedotnet publish
step to reduce thebin/test-compile
execution time.