Verify .NET runtime dependencies #50
Conversation
runesoerensen
force-pushed
the
verify-runtime-dependencies
branch
3 times, most recently
from
ad94542 to
b6c1050
Compare
runesoerensen
force-pushed
the
verify-runtime-dependencies
branch
from
ee392c5 to
89bef75
Compare
| @@ -40,6 +40,8 @@ | |||
| remote: Procfile declares types -> \\(none\\) | |||
| remote: Default types for buildpack -> foo | |||
| REGEX | |||
|
|
|||
| expect(app.run('bin/test-runtime.sh')).to match('All dynamically linked libraries were found.') | |||
There was a problem hiding this comment.
Worth noting app.run() doesn't check exit status by default, so if the success string match were ever removed, this would need to then assert against $?.exitstatus or $?.success?, per:
https://github.com/heroku/hatchet/?tab=readme-ov-file#build-versus-run-testing
There was a problem hiding this comment.
Yeah so an earlier version actually did check the exit status as suggested in the Hatchet docs, but caused RuboCop to balk at the use of $? (rather than $CHILD_STATUS). I lazily ended up just verifying the success output string match as you noticed :)
I've added it back in this commit using the $CHILD_STATUS alias for $?, and preferring be_success + be_zero predicate matchers.
Perhaps I should also submit a PR to update the Hatchet docs/README/templates to prefer the more readable alias and predicate matchers instead? Seems this would involve updating at least:
- https://github.com/heroku/hatchet/blob/68317439207663e54898be70a201aa4b21480c4f/lib/hatchet/templates/spec_helper.erb#L23
- https://github.com/heroku/hatchet/blob/68317439207663e54898be70a201aa4b21480c4f/README.md?plain=1#L261-L275
- https://github.com/heroku/hatchet/blob/68317439207663e54898be70a201aa4b21480c4f/spec/hatchet/app_spec.rb#L142-L148 (as this is referenced from the README and forms part of the documentation).
This PR:
liblttng-ust1to Heroku-22 and Heroku-24 base-images#346 isn't included in the currently published base images.Also see heroku/base-images#346 (review).