Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible testing with molecule #753

Merged
merged 8 commits into from
May 6, 2024
Merged

Conversation

harshavmb
Copy link
Contributor

In this tutorial, we will unit test ansible with molecule framework on Hetzner infrastructure.

I have read and understood the Contributor's Certificate of Origin available at the end of
https://raw.githubusercontent.com/hetzneronline/community-content/master/tutorial-template.md
and I hereby certify that I meet the contribution criteria described in it.
Signed-off-by: [Harshavardhan Musanalli and email address [email protected]]

@svenja11 svenja11 added the review wanted Request a review label Jan 8, 2024
@svenja11
Copy link
Collaborator

svenja11 commented Jan 17, 2024

Thank you for your contribution @harshavmb! I read through your tutorial and I made some updates, including:

  • I made some formatting updates
  • I added an example task for os_hardening_rule. The idea is that everyone can follow the tutorial even if they haven't created any rules before.
  • I changed the order of the YAML files to the order in which they would be run by Ansible so that it is easier to explain them step-by-step.
  • I updated your YAML files to use with_items.
  • I removed your explanation in the molecule.yml file and added it in a table below to make the YAML file more clear.
  • I removed your example output at the end.

Please let me know what you think.

Important: It looks like some of your text is copy&paste (e.g. Ansible docs). Please note that we have very strict rules regarding duplicated content (see Contribution Guidelines » Content)
Please update your content and make sure it is completely written by you. Otherwise, I cannot publish this tutorial at community.hetzner.com.


Once the English version is final, please update the German version accordingly. Please note that the German version is currently missing the first three steps. It begins with "Step 4 - Das Scenario-Layout".

@svenja11 svenja11 added needs action Something has to be updated and removed review wanted Request a review labels Jan 17, 2024
@svenja11
Copy link
Collaborator

@harshavmb Do you still plan to work on this tutorial?

@harshavmb
Copy link
Contributor Author

harshavmb commented Feb 23, 2024

Hi @svenja11 ,

I was on vacation for the past few weeks. Thanks for your review. I shall work on this PR soon & ask for your re review.

@svenja11 svenja11 added the stale closing soon... label Apr 10, 2024
@svenja11
Copy link
Collaborator

@harshavmb Do you still plan to work on this tutorial?

@harshavmb
Copy link
Contributor Author

Hi @svenja11 ,

Thanks for your review & apologies for this long delay!

I pushed the changes as per review. I copied few snippets directly from molecule documentation but I rearranged the wording a bit. Nevertheless, if you still spot some, please flag here.

I am not so confident with German version, but feel free to flag the changes for me here.

Looking forward to another round of review from you :)

@svenja11 svenja11 added review wanted Request a review and removed stale closing soon... labels May 2, 2024
@svenja11
Copy link
Collaborator

svenja11 commented May 3, 2024

Thank you for updating your tutorial @harshavmb. I looked at the German version and I have a few comments:

  • We decided to use "du" in all community-content tutorials. We still need to update older tutorials. However, for new tutorials we would like to already use "du". It would be great if you could update your German tutorial accordingly.

  • In the beginning of the German tutorial you say "Ansible roles", in the rest of the tutorial you say "Ansible-Rollen". In the German tutorial, please change "Ansible roles" to "Ansible-Rollen" for more consistency.

  • Ubuntu 24.04 just got available for Hetzner cloud servers on 25 April. It would be great if you could update the tutorial to already include the new OS.

  • In "Schritt 3 - Das Scenario-Layout", you forgot to translate the text that explains destroy.yml. (Right above step 4)

@svenja11 svenja11 removed the review wanted Request a review label May 3, 2024
@harshavmb
Copy link
Contributor Author

Hi @svenja11 ,

Thanks for the feedback. I did push the changes as asked by you.

Please perform another review.

Thanks,
Harsha

@svenja11 svenja11 added ready and removed needs action Something has to be updated labels May 6, 2024
@svenja11 svenja11 merged commit 109af82 into hetzneronline:master May 6, 2024
1 check passed
@harshavmb harshavmb deleted the molecule branch May 6, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants