-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible testing with molecule #753
Conversation
Thank you for your contribution @harshavmb! I read through your tutorial and I made some updates, including:
Please let me know what you think. Important: It looks like some of your text is copy&paste (e.g. Ansible docs). Please note that we have very strict rules regarding duplicated content (see Contribution Guidelines » Content) Once the English version is final, please update the German version accordingly. Please note that the German version is currently missing the first three steps. It begins with "Step 4 - Das Scenario-Layout". |
@harshavmb Do you still plan to work on this tutorial? |
Hi @svenja11 , I was on vacation for the past few weeks. Thanks for your review. I shall work on this PR soon & ask for your re review. |
@harshavmb Do you still plan to work on this tutorial? |
Hi @svenja11 , Thanks for your review & apologies for this long delay! I pushed the changes as per review. I copied few snippets directly from I am not so confident with German version, but feel free to flag the changes for me here. Looking forward to another round of review from you :) |
Thank you for updating your tutorial @harshavmb. I looked at the German version and I have a few comments:
|
Hi @svenja11 , Thanks for the feedback. I did push the changes as asked by you. Please perform another review. Thanks, |
In this tutorial, we will unit test
ansible
withmolecule
framework onHetzner
infrastructure.I have read and understood the Contributor's Certificate of Origin available at the end of
https://raw.githubusercontent.com/hetzneronline/community-content/master/tutorial-template.md
and I hereby certify that I meet the contribution criteria described in it.
Signed-off-by: [Harshavardhan Musanalli and email address [email protected]]