Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error on newer rusts #9

Closed
wants to merge 1 commit into from
Closed

Conversation

euank
Copy link

@euank euank commented Dec 10, 2017

See rust-lang/rust#18937 and related issues
for upstream discussion.

Compiling the previous code on modern rust results in:
error[E0276]: impl has stricter requirements than trait

This is the most trivial way to fix this issue.

A better fix might be possible. If the event loop were to migrate to
tokio and be external to the library (as hyper does these days), that
would allow expressing a more stringent lifetime on the handler.

For now, getting it back to a compiling state seems like a good step.

See rust-lang/rust#18937 and related issues
for upstream discussion.

Compiling the previous code on modern rust results in:
error[E0276]: impl has stricter requirements than trait

This is the most trivial way to fix this issue.

A better fix might be possible. If the event loop were to migrate to
tokio and be external to the library (as hyper does these days), that
would allow expressing a more stringent lifetime on the handler.

For now, getting it back to a compiling state seems like a good step.
@gyscos
Copy link

gyscos commented Jan 15, 2019

It's been over a year, this project might have been abandonned.
Maybe you could publish your fork on crates.io?

@euank
Copy link
Author

euank commented Jan 16, 2019

For what it's worth, I ended up using a combination of the vte library and pty-rs library to solve the problem I had instead of using this. The code I wrote for that is here, though note it is very specific to my exact use-case, so it's not really generically useful.

Since I don't actually use this code anywhere, I don't think I should maintain a fork of it.

@euank
Copy link
Author

euank commented Jun 1, 2020

It's been a couple years. I'll go ahead and close this. It looks like #10 has a more complete update as well regardless.

@euank euank closed this Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants