Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CLI docs command. #33

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Added CLI docs command. #33

merged 3 commits into from
Sep 16, 2024

Conversation

bre1470
Copy link
Member

@bre1470 bre1470 commented Sep 13, 2024 •
edited
Loading

Use npx connectors-morningstar docs.

@bre1470 bre1470 added the enhancement New feature or request label Sep 13, 2024
@bre1470 bre1470 self-assigned this Sep 13, 2024
@bre1470 bre1470 marked this pull request as ready for review September 13, 2024 14:26
@bre1470 bre1470 requested a review from goransle September 13, 2024 14:26
goransle
goransle reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@goransle goransle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some kind of encoding issue with http://localhost:8000/morningstar/time-series/time-series.md:

image

goransle
goransle approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@goransle goransle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it looks good 👍

@bre1470 bre1470 merged commit fc50a3d into main Sep 16, 2024
5 checks passed
@bre1470 bre1470 deleted the cli/docs branch September 16, 2024 08:25
@bre1470 bre1470 added this to the Next milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goransle goransle goransle approved these changes

Assignees

@bre1470 bre1470

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bre1470 @goransle