Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected URLs. #47

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Corrected URLs. #47

merged 2 commits into from
Nov 28, 2024

Conversation

bm64
Copy link
Member

@bm64 bm64 commented Nov 14, 2024

Corrected URLs in docs and demos.

@bm64 bm64 requested a review from pawelfus November 14, 2024 06:14
pawelfus
pawelfus approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Note: At this moment, there's no /connectors landing page, so we will redirect to Morningstar subpage. It will change once the landing page is ready.

Edit: Anything to add @bre1470?

@pawelfus pawelfus requested a review from bre1470 November 14, 2024 09:22
bre1470
bre1470 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

We could create a landing page for code.highcharts.com/connectors/ as an alternative.

@pawelfus pawelfus self-requested a review November 14, 2024 09:43
pawelfus
pawelfus requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one more: https://github.com/highcharts/connectors-morningstar/blob/corrected-docs-demos-urls/docs/connectors/morningstar/time-series/time-series.md -> Regulatory News Announcements is broken

@bm64 bm64 requested a review from pawelfus November 19, 2024 14:19
pawelfus
pawelfus approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pawelfus pawelfus added this to the Next milestone Nov 28, 2024
@pawelfus pawelfus merged commit 741d1e3 into main Nov 28, 2024
5 checks passed
@pawelfus pawelfus deleted the corrected-docs-demos-urls branch November 28, 2024 15:03
@pawelfus pawelfus removed the request for review from TorsteinHonsi November 28, 2024 15:03
@pawelfus pawelfus modified the milestones: v0.7.0, v1.0.0 Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelfus pawelfus pawelfus approved these changes

@bre1470 bre1470 bre1470 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bm64 @pawelfus @bre1470