Skip to content

Commit

Permalink
enh(fsharp) Global overhaul (#3348)
Browse files Browse the repository at this point in the history
* Fix character literals not being parsed
* Add missing keywords
* Fix parsing of generic type symbols
* Fix parsing of ML comments without space within
* Improve attributes parsing
* Add parsing of computation expressions
* Add parsing of preprocessor and FSI directives
* Add parsing of binary number literals
* Add unit tests

And also:
* Add detection for many types, literals, and builtins
* Add incomplete support for interpolated strings

Co-authored-by: Josh Goebel <[email protected]>
  • Loading branch information
mlaily and joshgoebel authored Oct 7, 2021
1 parent 42b12c9 commit 026a71f
Show file tree
Hide file tree
Showing 19 changed files with 1,009 additions and 62 deletions.
4 changes: 3 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Parser:

Grammars:

- enh(fsharp) rewrite most of the grammar, with many improvements [Melvyn Laïly][]
- enh(go) better type highlighting, add `error` type [Josh Goebel][]
- fix(js/ts) regex inside `SUBST` is no longer highlighted [Josh Goebel][]
- fix(python) added support for unicode identifiers (#3280) [Austin Schick][]
Expand Down Expand Up @@ -33,6 +34,7 @@ Grammars:
[Teletha]: https://github.com/teletha
[Nicolas Stucki]: https://github.com/nicolasstucki
[Bahnschrift]: https://github.com/Bahnschrift
[Melvyn Laïly]: https://github.com/mlaily
[katzeprior]: https://github.com/katzeprior


Expand All @@ -48,7 +50,7 @@ Parser:
- fix(types) Fix some type definition issues (#3274) [Josh Goebel][]
- fix(verilog) Fix directive handling (#3283) [Josh Goebel][]
- fix(verilog) Fix binary number false positives on `_` (#3283) [Josh Goebel][]
- enh(verilog) `__FILE__` and __`LINE__` constants (#3283) [Josh Goebel][]
- enh(verilog) `__FILE__` and `__LINE__` constants (#3283) [Josh Goebel][]
- enh(verilog) tighten keyword regex (#3283) [Josh Goebel][]


Expand Down
Loading

0 comments on commit 026a71f

Please sign in to comment.