Fix date_create_from_format when using | char #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using | in format string all not set fields are reset to unix 0 time
mcfedr
force-pushed
the
fix_create_from_format
branch
from
90c7062 to
d248a1c
Compare
|
The failed test seems to have nothing to do with this, and are actually I suspect related to daylight saving for LA time. |
|
And I'm pretty sure something is wrong in the php5 version because its crashing on my build server, but I dont know what I should be doing differnetly |
|
Thanks!👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using | in format string all not set fields are reset to unix 0 time
See | in http://php.net/manual/en/datetime.createfromformat.php
I am only slightly unsure about the memory management here, and use of
zval_ptr_dtor