Param 2: don't call param.objects() before super().__init__ in the explorer
#1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are green, so I will merge this. |
ahuang11
pushed a commit
that referenced
this pull request
Sep 27, 2023
…explorer (#1146) * call param.objects() after super().__init__ * add tests * update the docs * update error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explorer accepts in its constructor kwargs that are dispatched to the various controls (which wouldn't work well if two controls share the same attribute name but that's another issue) when they are instantiated. As such it needs to prune the kwargs before calling
super().__init__(**params). This was done by gathering all the controls classes calling.param.objects()and doing some filtering. Param 2 will raise an error (or a warning) whenparam.objects()is accessed beforesuper().__init__is called. In this PR I arrange the code to callparam.objects()aftersuper().__init__.