ImageStack support and aggregator fixes #1316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1315
With these changes:
rasterize=True, by='cat'
is equivalent torasterize=True, aggregator=ds.count_cat('cat')
eltype
is correctly set toImageStack
when an ImageStack should be returned, so the options are correctly applied to the output of the operationI've moved the logic that infers whether a datashaded plot is categorical or not and the aggregator to a method that is used in two places.