Apply suggestions from code review

holoviz · Jul 2, 2023 · bb45344 · bb45344
1 parent 0b97692
commit bb45344
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/doc/how_to/callbacks/defer_load.md b/doc/how_to/callbacks/defer_load.md
@@ -33,7 +33,7 @@ def some_long_running_task():
 pn.panel(some_long_running_task).servable()
 ```
 
-![panel-longrunning-task-example](https://user-images.githubusercontent.com/42288570/245752515-1329b4c3-da45-41e7-b3b5-b1b4f09eecd4.gif)
+![panel-longrunning-task-example](https://assets.holoviz.org/panel/gifs/long_running_task.gif)
 
 Now lets learn how to defer long running tasks to after the application has loaded.
 
@@ -55,7 +55,7 @@ def long_running_task():
 pn.Column("# I'm shown on load", long_running_task).servable()
 ```
 
-![panel-defer-all-example](https://user-images.githubusercontent.com/42288570/245752511-b2970c4c-7144-4b1a-af36-4c90b1873de6.gif)
+![panel-defer-all-example](https://assets.holoviz.org/panel/gifs/defer_all_tasks.gif)
 
 ## Defer Specific Tasks
 
@@ -83,4 +83,4 @@ pn.Column(
 ).servable()
 ```
 
-![panel-defer-specific-example](https://user-images.githubusercontent.com/42288570/245752506-9ac676e9-65b2-4d9d-a01a-ce01a12dfda4.gif)
+![panel-defer-specific-example](https://assets.holoviz.org/panel/gifs/defer_specific_task.gif)
diff --git a/doc/how_to/callbacks/load.md b/doc/how_to/callbacks/load.md
@@ -33,7 +33,7 @@ some_long_running_task()
 layout.servable()
 ```
 
-![panel-longrunning-task-example](https://user-images.githubusercontent.com/42288570/245752515-1329b4c3-da45-41e7-b3b5-b1b4f09eecd4.gif)
+![panel-longrunning-task-example](https://assets.holoviz.org/panel/gifs/long_load.gif)
 
 Now lets learn how to defer long running tasks to after the application has loaded.
 
@@ -56,7 +56,7 @@ pn.state.onload(some_long_running_task)
 layout.servable()
 ```
 
-![panel-onload-example](https://user-images.githubusercontent.com/42288570/250338232-3777ff1e-4832-4cc9-aac0-03875b8c69f5.gif)
+![panel-onload-example](https://assets.holoviz.org/panel/gifs/onload_callback.gif)
 
 Note that `pn.state.onload` accepts both *sync* and *async* functions.
 
@@ -88,24 +88,26 @@ class AppState(param.Parameterized):
         time.sleep(2)
         state.data = pd.DataFrame({"x": [1, 2, 3, 4], "y": [1, 3, 2, 4]})
 
-def loading_indicator():
-    return pn.indicators.LoadingSpinner(value=True, height=25, width=25, align="center")
+def loading_indicator(label):
+    return pn.indicators.LoadingSpinner(
+        value=True, name=label, size=25, align="center"
+    )
 
 def short_running_task():
     return "# I'm shown on load"
 
 def table(data):
     if data is None:
-        return pn.Row(loading_indicator(), "Loading data")
+        return loading_indicator("Loading data")
 
     return pn.pane.DataFrame(data)
 
 def plot(data):
     if data is None:
-        yield pn.Row(loading_indicator(), "Waiting for data")
+        yield loading_indicator("Waiting for data")
         return
 
-    yield pn.Row(loading_indicator(), "Transforming data")
+    yield loading_indicator("Transforming data")
     time.sleep(2)  # Some long running transformation
     yield data.hvplot()
 
@@ -119,4 +121,4 @@ pn.Column(
 ).servable()
 ```
 
-![panel-onload-dependent-tasks-example](https://user-images.githubusercontent.com/42288570/245752488-b2963489-bdff-4323-b801-03a763992af9.gif)
+![panel-onload-dependent-tasks-example](https://assets.holoviz.org/panel/gifs/onload_dependent.gif)