Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support step and format on DateSlider #2731

Closed
MarcSkovMadsen opened this issue Sep 12, 2021 · 3 comments
Closed

Support step and format on DateSlider #2731

MarcSkovMadsen opened this issue Sep 12, 2021 · 3 comments
Labels
good first issue Good for newcomers type: enhancement Minor feature or improvement to an existing feature
Milestone

Comments

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Sep 12, 2021

The current version of Panel is 0.12.1.

If I look at the Bokeh DateSlider I can see it supports a step and format which the Panel DateSlider does not.

I think supporting that would be quite useful for Panel as that would allow sliding through other timeperiods than days down to milliseconds as far as I can see.

Todo

It's probably as simple as

  • Add step and format parameters to Panels DataSlider
  • Add tests or test manually that it works
  • Update reference guide.

Additional Context

It would for example increase the possibilities for Creating a dynamic map with datetime range. See #673

@MarcSkovMadsen MarcSkovMadsen added TRIAGE Default label for untriaged issues type: enhancement Minor feature or improvement to an existing feature good first issue Good for newcomers and removed TRIAGE Default label for untriaged issues labels Sep 12, 2021
@MarcSkovMadsen MarcSkovMadsen added this to the Wishlist milestone Sep 12, 2021
@Axeldnahcram
Copy link
Contributor

Axeldnahcram commented Nov 23, 2022

Hi, long time lurker but I guess I kinda want to get involved after using panel for more than a year now. How can I push my changes to a branch to make my first PR @MarcSkovMadsen ?
I also added the format option in the daterangeslider as requested in #2894

@Axeldnahcram
Copy link
Contributor

I guess I need to fork my own version of panel. I will do it tonight

@maximlt
Copy link
Member

maximlt commented Nov 24, 2022

Hi @Axeldnahcram,

Yes indeed as an external contributor you must fork this repository, then create a new branch in your local fork and push it to your remote repo. At this point Github will offer you to merge your branch into this repository, that's a Pull Request.

You can find the developer instructions here for more details: https://panel.holoviz.org/developer_guide/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants