Now support step format in date sliders #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4152 +/- ##
=======================================
Coverage 83.58% 83.58%
=======================================
Files 224 224
Lines 33394 33397 +3
=======================================
+ Hits 27912 27916 +4
+ Misses 5482 5481 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
This looks good, thanks! In general unless the model is implemented in Panel itself (i.e. not just wrapping something in Bokeh) we add UI tests but since that's not the case here this is fine. You could add a test that checks that the bokeh model returned by obj.get_root() correctly sets the format and is updated when the format parameter is changed but it's not critical. I'll merge and look at why the tests are being flakey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issues are 2731 and 2894.
I have not really added tests since the formatting is done in the JS of the bokeh object and I feel like testing must be done on their side rather than ours then. And I kinda do not really like simply testing that if I call
slider=Slider(format=5)thenslider.format=5but if needed I can add it.If needed I can also add some BFSoup checker somewhere to test both steps and format, of course if you have an original example of pr that had to deal with that I will be happy to comply to any specific test format.
On a side note, it looks like the
.controls()function is oftentimes not displaying the full controls. I would be happy to investigate.Also if you have a tool that strips the notebooks of the cell metadata updates so that my commits on notebooks are clean I would be very happy.
It is my first ever PR on this project, let me know if there are any specifics to consider when contributing.
Have a good day