-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bokeh 3 - Fix tests #4140
Merged
Merged
Bokeh 3 - Fix tests #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
commented
Nov 21, 2022
Codecov Report
@@ Coverage Diff @@
## branch-1.0 #4140 +/- ##
==============================================
- Coverage 83.57% 74.15% -9.42%
==============================================
Files 223 222 -1
Lines 33234 33314 +80
==============================================
- Hits 27774 24705 -3069
- Misses 5460 8609 +3149
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
pushed a commit
that referenced
this pull request
Dec 6, 2022
philippjfr
pushed a commit
that referenced
this pull request
Jan 12, 2023
philippjfr
pushed a commit
that referenced
this pull request
Jan 17, 2023
philippjfr
pushed a commit
that referenced
this pull request
Jan 25, 2023
philippjfr
pushed a commit
that referenced
this pull request
Jan 27, 2023
philippjfr
pushed a commit
that referenced
this pull request
Feb 2, 2023
philippjfr
pushed a commit
that referenced
this pull request
Feb 8, 2023
philippjfr
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the tests
styles["background"]
Also:
Background
A lot of the failing test on branch-1.0 is because Bokeh 3 no longer uses
model.background
but instead usesmodel.styles["background"]
.This PR fixes these failing tests by converting
model.background
->model.styles["background"]
and then gives a warning.The changes made in this PR do not work in Firefox and will be fixed in bokeh/bokeh#12633.