Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh 3 - Fix tests #4140

Merged
merged 9 commits into from
Nov 25, 2022
Merged

Bokeh 3 - Fix tests #4140

merged 9 commits into from
Nov 25, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 21, 2022

Fixes the tests

  • Update background to styles["background"]
  • Tabulator tests.
  • Dial not having a _widget_type.

Also:

  • Remove a version guard for bokeh.

Background

A lot of the failing test on branch-1.0 is because Bokeh 3 no longer uses model.background but instead uses model.styles["background"].

This PR fixes these failing tests by converting model.background -> model.styles["background"] and then gives a warning.

The changes made in this PR do not work in Firefox and will be fixed in bokeh/bokeh#12633.

@hoxbro hoxbro changed the title Bokeh 3 - Support styles['background'] Bokeh 3 - Fix tests Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #4140 (9a08244) into branch-1.0 (c4b17ba) will decrease coverage by 9.41%.
The diff coverage is 87.27%.

@@              Coverage Diff               @@
##           branch-1.0    #4140      +/-   ##
==============================================
- Coverage       83.57%   74.15%   -9.42%     
==============================================
  Files             223      222       -1     
  Lines           33234    33314      +80     
==============================================
- Hits            27774    24705    -3069     
- Misses           5460     8609    +3149     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 74.15% <87.27%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/command/convert.py 32.35% <ø> (+0.92%) ⬆️
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)
panel/io/state.py 61.97% <0.00%> (-7.85%) ⬇️
panel/layout/spacer.py 74.07% <0.00%> (ø)
panel/models/__init__.py 100.00% <ø> (ø)
panel/pane/image.py 79.06% <ø> (-0.47%) ⬇️
panel/template/fast/theme.py 100.00% <ø> (ø)
panel/template/material/__init__.py 100.00% <ø> (ø)
panel/tests/io/test_embed.py 99.42% <ø> (ø)
panel/tests/layout/test_tabs.py 100.00% <ø> (ø)
... and 121 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit b4b0f3a into branch-1.0 Nov 25, 2022
@philippjfr philippjfr deleted the background_test branch November 25, 2022 11:49
philippjfr pushed a commit that referenced this pull request Dec 6, 2022
philippjfr pushed a commit that referenced this pull request Jan 12, 2023
philippjfr pushed a commit that referenced this pull request Jan 17, 2023
philippjfr pushed a commit that referenced this pull request Jan 25, 2023
philippjfr pushed a commit that referenced this pull request Jan 27, 2023
philippjfr pushed a commit that referenced this pull request Feb 2, 2023
philippjfr pushed a commit that referenced this pull request Feb 8, 2023
philippjfr pushed a commit that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants