-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate sizing mode #4360
Merged
Merged
Propagate sizing mode #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit.ci autofix |
54d1def
to
4f41caf
Compare
Codecov Report
@@ Coverage Diff @@
## main #4360 +/- ##
==========================================
+ Coverage 82.79% 82.82% +0.03%
==========================================
Files 240 240
Lines 34637 34789 +152
==========================================
+ Hits 28677 28815 +138
- Misses 5960 5974 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that any dynamic components like
ParamFunction
,ParamMethod
andInteractive
reflect the parameters (especially thesizing_mode
) of the components they are wrapping. It also propagates responsive sizing modes on a HoloViews/Bokeh object to the pane wrapping it ensuring that sizing modes and other options can propagate upwards from a plot all the way to a dynamic pane.