Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate sizing mode #4360

Merged
merged 7 commits into from
Jan 30, 2023
Merged

Propagate sizing mode #4360

merged 7 commits into from
Jan 30, 2023

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 29, 2023

This PR ensures that any dynamic components like ParamFunction, ParamMethod and Interactive reflect the parameters (especially the sizing_mode) of the components they are wrapping. It also propagates responsive sizing modes on a HoloViews/Bokeh object to the pane wrapping it ensuring that sizing modes and other options can propagate upwards from a plot all the way to a dynamic pane.

@philippjfr
Copy link
Member Author

pre-commit.ci autofix

@philippjfr philippjfr force-pushed the propagate_sizing_mode branch from 54d1def to 4f41caf Compare January 29, 2023 16:35
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #4360 (4b5e281) into main (95c244b) will increase coverage by 0.03%.
The diff coverage is 97.14%.

@@            Coverage Diff             @@
##             main    #4360      +/-   ##
==========================================
+ Coverage   82.79%   82.82%   +0.03%     
==========================================
  Files         240      240              
  Lines       34637    34789     +152     
==========================================
+ Hits        28677    28815     +138     
- Misses       5960     5974      +14     
Flag Coverage Δ
ui-tests 38.27% <29.71%> (-0.06%) ⬇️
unitexamples-tests 73.82% <97.14%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/plot.py 63.74% <92.30%> (+2.27%) ⬆️
panel/tests/pane/test_holoviews.py 99.16% <96.61%> (-0.37%) ⬇️
panel/pane/holoviews.py 80.40% <98.36%> (+1.21%) ⬆️
panel/interact.py 74.30% <100.00%> (+1.52%) ⬆️
panel/pane/base.py 87.95% <100.00%> (+0.45%) ⬆️
panel/tests/pane/test_base.py 96.07% <100.00%> (ø)
panel/tests/test_interact.py 99.00% <100.00%> (ø)
panel/tests/util.py 89.32% <0.00%> (-1.95%) ⬇️
panel/io/state.py 70.63% <0.00%> (-0.18%) ⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 888667b into main Jan 30, 2023
@philippjfr philippjfr deleted the propagate_sizing_mode branch January 30, 2023 13:55
philippjfr added a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant