Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not error on deserialization errors in notebooks #4927

Merged
merged 1 commit into from
May 24, 2023

Conversation

philippjfr
Copy link
Member

In the notebook where the errors appear inline the deserialization errors should not trigger tracebacks as the user likely can't do anything about them.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #4927 (e6e2570) into main (95bdcb2) will decrease coverage by 0.04%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main    #4927      +/-   ##
==========================================
- Coverage   83.43%   83.40%   -0.04%     
==========================================
  Files         270      270              
  Lines       38171    38175       +4     
==========================================
- Hits        31849    31839      -10     
- Misses       6322     6336      +14     
Flag Coverage Δ
ui-tests 40.84% <12.50%> (-0.05%) ⬇️
unitexamples-tests 73.39% <12.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/viewable.py 65.45% <12.50%> (-0.40%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 94690bb into main May 24, 2023
@philippjfr philippjfr deleted the deserialize_error branch May 24, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant