Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress sizing mode #5051

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix progress sizing mode #5051

merged 1 commit into from
Jun 8, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jun 6, 2023

Fixes #5046

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #5051 (37eddc8) into main (e4f4c5d) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5051      +/-   ##
==========================================
+ Coverage   80.90%   81.09%   +0.19%     
==========================================
  Files         274      274              
  Lines       39109    39108       -1     
==========================================
+ Hits        31641    31715      +74     
+ Misses       7468     7393      -75     
Flag Coverage Δ
ui-tests 40.55% <100.00%> (+1.06%) ⬆️
unitexamples-tests 71.13% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/widgets/indicators.py 73.03% <100.00%> (-0.05%) ⬇️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

Test failures unrelated (and already resolved).

@philippjfr philippjfr merged commit 2f0eaf3 into main Jun 8, 2023
@philippjfr philippjfr deleted the fix_progress_sizing_mode branch June 8, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pn.widgets.Progress does not respect pn.config.sizing_mode
2 participants